Skip to content

community activities samples#7

Open
viogroza wants to merge 2 commits intomainfrom
community_activities_samples
Open

community activities samples#7
viogroza wants to merge 2 commits intomainfrom
community_activities_samples

Conversation

@viogroza
Copy link
Copy Markdown
Contributor

@viogroza viogroza commented May 1, 2026

Added coded sample for Credentials
Added coded sample for Database
Added coded sample for FTP
Added coded sample for Java
Added coded sample for Python

Copy link
Copy Markdown

@alexandru-petre alexandru-petre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review of the 5 new coded sample projects. Substantive review surface = the 5 *.cs workflow files + 2 .java sources + README; auto-generated XAML / entry-points.json / .codedworkflows/Connections*.cs were skipped.

Verdict: NEEDS CHANGES.

Highlights (full inline comments below):

  • P0 Broken Console.WriteLine interpolation in Credentials sample (missing $).
  • P1 Delay(...) task discarded in Python sample — no actual wait happens.
  • P1 Python scope uses sync using instead of await using, inconsistent with FTP/Java siblings.
  • P5 Credentials sample logs Password to console — sample teaches the wrong instinct.
  • P5 Hardcoded FTP credentials with no pointer to credential assets / vault.
  • P5 SQL built via string.Format — sample teaches the canonical SQL-injection pattern.
  • P2 Namespace mismatches: DatabaseCodedDemo (folder is CodedDatabaseDemo) and bare Java.
  • P3 Unused using directives in every new .cs file (FTP sample still imports UiPath.Excel.* from copy-paste).
  • P3 Hardcoded JDK 25.0.2.10 / Python 3.13 paths break the sample for everyone except the author.

Positive observations:

  • Good await using pattern in FTP and Java samples.
  • Java sources (Coordinate.java, StaticMethods.java) are clean and appropriately demo-scoped.
  • README entries follow the existing one-line, alphabetized convention.

Comment thread CodedCredentialsDemo/CodedCredentialsT.cs Outdated
Comment thread CodedCredentialsDemo/CodedCredentialsT.cs Outdated
Comment thread CodedCredentialsDemo/CodedCredentialsT.cs
Comment thread CodedCredentialsDemo/CodedCredentialsT.cs
Comment thread CodedDatabaseDemo/SqliteCodedTests.cs
Comment thread CodedJavaDemo/JavaCodedTests.cs
Comment thread CodedPythonDemo/PythonTests.cs Outdated
Comment thread CodedPythonDemo/PythonTests.cs
Comment thread CodedPythonDemo/PythonTests.cs
Comment thread CodedPythonDemo/PythonTests.cs
Address review findings
@viogroza viogroza requested a review from alexandru-petre May 1, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants